Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor repro: split logic for planning stages to run for repro #9690

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

skshetry
Copy link
Member

@skshetry skshetry commented Jul 3, 2023

The planning logic has now been moved to plan_repro api, that allows us to test without creating stages.

The planning logic has now been moved to `plan_repro` api, that allows us
to test without creating stages.
@skshetry skshetry requested a review from a team July 3, 2023 10:30
@skshetry skshetry added the refactoring Factoring and re-factoring label Jul 3, 2023
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Patch coverage: 97.29% and project coverage change: +0.28 🎉

Comparison is base (b7b6642) 90.26% compared to head (0d67e5b) 90.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9690      +/-   ##
==========================================
+ Coverage   90.26%   90.55%   +0.28%     
==========================================
  Files         480      480              
  Lines       36359    36385      +26     
  Branches     5226     5227       +1     
==========================================
+ Hits        32820    32948     +128     
+ Misses       2926     2849      -77     
+ Partials      613      588      -25     
Impacted Files Coverage Δ
tests/unit/repo/test_reproduce.py 97.29% <96.29%> (-2.71%) ⬇️
dvc/repo/reproduce.py 98.66% <97.87%> (-0.02%) ⬇️

... and 26 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@skshetry skshetry merged commit 2becfd9 into iterative:main Jul 3, 2023
20 checks passed
@skshetry skshetry deleted the refactor-plan-repro branch July 3, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Factoring and re-factoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant